From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752065AbdB0UbD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Feb 2017 15:31:03 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47061 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751617AbdB0Ua5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Feb 2017 15:30:57 -0500
X-ME-Sender: <xms:H4y0WGAj1wjsCmA27O9N_on5cU7IKYHZMe69qNNKq-CKmNxMTL0Nyg>
X-Sasl-enc: CzP6aCnz/qsro6WvZwsE1bG6m+Z7XE7vgKhvfMAQt7nn 1488227359
Date: Tue, 28 Feb 2017 07:29:15 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
        devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code
 in comments.
Message-ID: <20170227202915.GA10862@eros>
References: <20170226160820.GA20046@arushi-HP-Pavilion-Notebook>
 <20170227144852.GA24465@kroah.com>
 <CA+XqjF-7SfgGkcHGhraz2R=8qV4Vgqiky+u+qSJNTMGr__JnTg@mail.gmail.com>
 <alpine.DEB.2.20.1702271606420.3032@hadrien>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.DEB.2.20.1702271606420.3032@hadrien>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
> 
> 
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
> 
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >       On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> >       > Commenting Code Is a Bad Idea.
> >       > Comments are their to explain the code and how the code
> >       achieves its
> >       > goal and as codes in the comments  does not explain what the
> >       code is
> >       > doing so there is no use of commenting them.
> >       > So in this patch codes in the comments are removed.
> >       >
> >       > Signed-off-by: Arushi Singhal
> >       <arushisinghal19971997@gmail.com>
> >       > ---
> >       >  changes in v2
> >       >  - subject lines is made short.
> >       >
> >       >  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> >       >  1 file changed, 4 deletions(-)
> >
> >       This patch does not apply against my staging-testing branch :(
> >
> >
> > why?
> 
> You should figure this out yourself.  Pull Greg's tree again, and try to
> apply your patch.  It's deterministic, so you should have the same
> information that he has.

I have only just worked this out Arushi so I thought I'd share. You
may want to read up on remote tracking branches in git and set up a
branch tracking Greg's staging-testing branch. Then create (checkout
-b) your development branches from that branch.

Good luck,
Tobin.