From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752120AbdB0WPh (ORCPT ); Mon, 27 Feb 2017 17:15:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41740 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdB0WOo (ORCPT ); Mon, 27 Feb 2017 17:14:44 -0500 Date: Mon, 27 Feb 2017 23:14:00 +0100 From: Andrea Arcangeli To: Mike Kravetz Cc: Mike Rapoport , Linus Torvalds , Shuah Khan , Stephen Rothwell , linux-kselftest@vger.kernel.org, LKML , "davem@davemloft.net" Subject: Re: [GIT PULL] Kselftest update for 4.11-rc1 Message-ID: <20170227221400.GE5816@redhat.com> References: <5355691a-e765-51d9-d6ab-cc5310fa30f0@osg.samsung.com> <20170226113744.GA17152@rapoport-lnx> <06e6875c-18bd-ccac-366d-b796d3200766@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06e6875c-18bd-ccac-366d-b796d3200766@oracle.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 27 Feb 2017 22:14:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, Feb 26, 2017 at 12:40:36PM -0800, Mike Kravetz wrote: > Another option is to only have a single userfaultfd executable and pass > an option (anon, hugetlb, shmem ...) that indicates the type of pages/mapping > to test. That sounds good to me. I guess it was quicker and it generated more compact diffs to differentiate based on #ifdefs initially, but it makes sense to unify those binaries into one now, as we don't mind the size of the selftest executable. run_vmtests takes custom parameters already, it will just take one more then. Thanks, Andrea