From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Al Viro <viro@zeniv.linux.org.uk>, Jeff Mahoney <jeffm@suse.com>
Cc: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH] uapi: move struct reiserfs_security_handle out from linux/reiserfs_xattr.h
Date: Tue, 28 Feb 2017 03:53:28 +0300 [thread overview]
Message-ID: <20170228005328.GA27363@altlinux.org> (raw)
As there seems to be no way struct reiserfs_security_handle could be
passed between the kernel and userspace, move its definition from the
UAPI header to a private header fs/reiserfs/xattr.h which is the only
file in the tree that includes linux/reiserfs_xattr.h.
This also fixes the following linux/reiserfs_xattr.h userspace
compilation error:
/usr/include/linux/reiserfs_xattr.h:21:2: error: unknown type name 'size_t'
size_t length;
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
Perhaps the whole file could be moved out from the UAPI.
I'm not sure about that, though.
fs/reiserfs/xattr.h | 6 ++++++
include/uapi/linux/reiserfs_xattr.h | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/reiserfs/xattr.h b/fs/reiserfs/xattr.h
index 613ff5a..1ae77ed 100644
--- a/fs/reiserfs/xattr.h
+++ b/fs/reiserfs/xattr.h
@@ -4,6 +4,12 @@
#include <linux/rwsem.h>
#include <linux/xattr.h>
+struct reiserfs_security_handle {
+ const char *name;
+ void *value;
+ size_t length;
+};
+
struct inode;
struct dentry;
struct iattr;
diff --git a/include/uapi/linux/reiserfs_xattr.h b/include/uapi/linux/reiserfs_xattr.h
index 38fdd64..e07f4c7 100644
--- a/include/uapi/linux/reiserfs_xattr.h
+++ b/include/uapi/linux/reiserfs_xattr.h
@@ -15,10 +15,4 @@ struct reiserfs_xattr_header {
__le32 h_hash; /* hash of the value */
};
-struct reiserfs_security_handle {
- const char *name;
- void *value;
- size_t length;
-};
-
#endif /* _LINUX_REISERFS_XATTR_H */
--
ldv
reply other threads:[~2017-02-28 1:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228005328.GA27363@altlinux.org \
--to=ldv@altlinux.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox