From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alexander Potapenko <glider@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Tobias Regnery <tobias.regnery@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
lkp@01.org,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [lkp-robot] [x86/mm/ptdump] 243b72aae2: WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page
Date: Tue, 28 Feb 2017 09:19:23 +0800 [thread overview]
Message-ID: <20170228011923.GC9855@yexl-desktop> (raw)
In-Reply-To: <20170228011140.ef61008afb57976a74ead279@kernel.org>
On 02/28, Masami Hiramatsu wrote:
>On Mon, 27 Feb 2017 16:01:34 +0300
>Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>> On 02/27/2017 04:03 AM, kernel test robot wrote:
>> >
>> > FYI, we noticed the following commit:
>> >
>> > commit: 243b72aae28ca1032284028323bb81c9235b15c9 ("x86/mm/ptdump: Optimize check for W+X mappings for CONFIG_KASAN=y")
>> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>
>> ...
>> >
>> > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>> >
>> >
>> > +-----------------------------------------------------+------------+------------+
>> > | | 5b1ad68f9b | 243b72aae2 |
>> > +-----------------------------------------------------+------------+------------+
>> > | boot_successes | 0 | 0 |
>> > | boot_failures | 8 | 6 |
>> > | BUG:KASAN:slab-out-of-bounds | 8 | 6 |
>> > | WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 0 | 6 |
>> > +-----------------------------------------------------+------------+------------+
>>
>> Ok, I reproduced this, but it's definitely caused *not* by 243b72aae28.
>> This WARN is also reproducible on the parent commit 5b1ad68f9b.
>> The only difference here is that on parent one needs dozens of seconds to reach this WARNING.
>> It seems that this time difference somehow confused the robot.
>>
>> As for the warning itself, it caused by kprobes. krpobe code use module_alloc() which
>> creates these RWX mappings.
>> I'm not sure how to fix this as AFAIK kprobes actually need RWX mapping.
>
>Thanks! I also noticed this issue. I actually have a plan to make kprobes with R+X mappings (as ftrace does).
>I'll queue this on my TODO list.
>
Good to know that, feel free to ask me to verify your fix if needed.
Thanks,
Xiaolong
>
>
>--
>Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-02-28 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 1:03 [lkp-robot] [x86/mm/ptdump] 243b72aae2: WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page kernel test robot
2017-02-27 13:01 ` Andrey Ryabinin
2017-02-27 16:11 ` Masami Hiramatsu
2017-02-28 1:19 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228011923.GC9855@yexl-desktop \
--to=xiaolong.ye@intel.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=aryabinin@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=tglx@linutronix.de \
--cc=tobias.regnery@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox