From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751981AbdB1BUc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 27 Feb 2017 20:20:32 -0500
Received: from mga14.intel.com ([192.55.52.115]:13054 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751723AbdB1BU1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Feb 2017 20:20:27 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,216,1484035200"; 
   d="scan'208";a="1135770329"
Date: Tue, 28 Feb 2017 09:19:23 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexander Potapenko <glider@google.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Tobias Regnery <tobias.regnery@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>, lkp@01.org,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [lkp-robot] [x86/mm/ptdump] 243b72aae2:
 WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page
Message-ID: <20170228011923.GC9855@yexl-desktop>
References: <20170227010341.GA32284@yexl-desktop>
 <34aa4f8e-190a-8895-bf43-22d3f08efd17@virtuozzo.com>
 <20170228011140.ef61008afb57976a74ead279@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170228011140.ef61008afb57976a74ead279@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/28, Masami Hiramatsu wrote:
>On Mon, 27 Feb 2017 16:01:34 +0300
>Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>> On 02/27/2017 04:03 AM, kernel test robot wrote:
>> > 
>> > FYI, we noticed the following commit:
>> > 
>> > commit: 243b72aae28ca1032284028323bb81c9235b15c9 ("x86/mm/ptdump: Optimize check for W+X mappings for CONFIG_KASAN=y")
>> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>> 
>> ...
>> > 
>> > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>> > 
>> > 
>> > +-----------------------------------------------------+------------+------------+
>> > |                                                     | 5b1ad68f9b | 243b72aae2 |
>> > +-----------------------------------------------------+------------+------------+
>> > | boot_successes                                      | 0          | 0          |
>> > | boot_failures                                       | 8          | 6          |
>> > | BUG:KASAN:slab-out-of-bounds                        | 8          | 6          |
>> > | WARNING:at_arch/x86/mm/dump_pagetables.c:#note_page | 0          | 6          |
>> > +-----------------------------------------------------+------------+------------+
>> 
>> Ok, I reproduced this, but it's definitely caused *not* by 243b72aae28.
>> This WARN is also reproducible on the parent commit 5b1ad68f9b.
>> The only difference here is that on parent one needs dozens of seconds to reach this WARNING.
>> It seems that this time difference somehow confused the robot.
>> 
>> As for the warning itself, it caused by kprobes. krpobe code use module_alloc() which
>> creates these RWX mappings.
>> I'm not sure how to fix this as AFAIK kprobes actually need RWX mapping.
>
>Thanks! I also noticed this issue. I actually have a plan to make kprobes with R+X mappings (as ftrace does).
>I'll queue this on my TODO list.
>

Good to know that, feel free to ask me to verify your fix if needed.

Thanks,
Xiaolong
>
>
>-- 
>Masami Hiramatsu <mhiramat@kernel.org>