From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752648AbdB1NLG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 08:11:06 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:45414 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752628AbdB1NLD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 08:11:03 -0500
Date: Tue, 28 Feb 2017 10:19:17 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: Lee Jones <lee@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>,
        dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>, alsa-devel@alsa-project.org,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Stephen Warren <swarren@wwwdotorg.org>, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] drm/vc4: Add HDMI audio support
Message-ID: <20170228101917.40810aa9@bbrezillon>
In-Reply-To: <20170227202803.12855-2-eric@anholt.net>
References: <20170227202803.12855-1-eric@anholt.net>
        <20170227202803.12855-2-eric@anholt.net>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 27 Feb 2017 12:28:02 -0800
Eric Anholt <eric@anholt.net> wrote:

> The HDMI encoder IP embeds all needed blocks to output audio, with a
> custom DAI called MAI moving audio between the two parts of the HDMI
> core.  This driver now exposes a sound card to let users stream audio
> to their display.
> 
> Using the hdmi-codec driver has been considered here, but MAI meant
> having to significantly rework hdmi-codec, and it would have left
> little shared code with the I2S mode anyway.
> 
> The encoder requires that the audio be SPDIF-formatted frames only,
> which alsalib will format-convert for us.
> 
> This patch is the combined work of Eric Anholt (initial register setup
> with a separate dmaengine driver and using simple-audio-card) and
> Boris Brezillon (moving it all into HDMI, massive debug to get it
> actually working), and which Eric has the permission to release.
> 
> v2: Drop "-audio" from sound card name, since that's already implied
>     (suggestion by Boris)
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>