Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

Peter Zijlstra
2017-02-28T13:44:05Z

On Tue, Feb 28, 2017 at 01:45:07PM +0100, Peter Zijlstra wrote:
> On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote:
> > + /*
> > + * struct held_lock does not have an indicator whether in nmi.
> > + */
> > + int nmi;
>
> Do we really need this? Lockdep doesn't really know about NMI context,
> so its weird to now partially introduce it.

That is, see how nmi_enter() includes lockdep_off().