From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbdB1RM5 (ORCPT ); Tue, 28 Feb 2017 12:12:57 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34117 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdB1RM1 (ORCPT ); Tue, 28 Feb 2017 12:12:27 -0500 Date: Tue, 28 Feb 2017 20:11:14 +0300 From: Cyrill Gorcunov To: Jason Baron Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, viro@zeniv.linux.org.uk, akpm@linuxfoundation.org, avagin@virtuozzo.com, xemul@virtuozzo.com, mtk.manpages@gmail.com, kir@openvz.org, luto@amacapital.net Subject: Re: [RFC 0/3] fs,epoll: Add ability to call kcmp to find target files Message-ID: <20170228171114.GB28817@uranus.lan> References: <20170221165944.180372636@openvz.org> <39a65773-a58e-032b-1448-5e03bf78d763@akamai.com> <20170221205434.GD27653@uranus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170221205434.GD27653@uranus> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 11:54:34PM +0300, Cyrill Gorcunov wrote: > > I think it should be ebough (together with sdev and pos). But will > look more closely tomorrow once I sit implementing criu support :) > (that's why it is early rfc, to gather comments) FWIW, yes, it is enough for primary sorting key. Once it matches the key from other anon block we use kcmp call to find exact match (kid_epoll_lookup lookups over primary keys generated by inode/sdev/pos, and then using kcmp we walk over files) https://github.com/cyrillos/criu/blob/epoll-tgt-3/criu/kcmp-ids.c#L158 Cyrill