From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdB1S01 (ORCPT ); Tue, 28 Feb 2017 13:26:27 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35726 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdB1S0J (ORCPT ); Tue, 28 Feb 2017 13:26:09 -0500 Date: Tue, 28 Feb 2017 10:26:05 -0800 From: Dmitry Torokhov To: Andy Shevchenko Cc: Mark Brown , linux-spi , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/3] spi: allow registering empty spi_board_info lists Message-ID: <20170228182605.GB20776@dtor-ws> References: <20170228041857.13292-1-dmitry.torokhov@gmail.com> <20170228041857.13292-4-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 04:01:46PM +0200, Andy Shevchenko wrote: > On Tue, Feb 28, 2017 at 6:18 AM, Dmitry Torokhov > wrote: > > Many boards form list of spi_board_info entries depending on config, > > and it is possible to end up with empty list. Do not report error > > in such cases. > > If there is an actual case already it would be better to make the > patch first in the series with Cc: stable@. arch/blackfin/mach-bf533/boards/ezkit.c: you can get config convoluted enough so that you'll end up with empty array. But nobody checks the result of the call, so the failure is not visible. There is no need to cc stable@ for this. > > FWIW: > Reviewed-by: Andy Shevchenko > Thanks. -- Dmitry