public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chetan Sethi <cpsethi369@gmail.com>
Cc: devel@driverdev.osuosl.org, punitvara@gmail.com,
	wsa@the-dreams.de, linux-kernel@vger.kernel.org, shiva@exdev.nl
Subject: Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters
Date: Tue, 28 Feb 2017 20:27:32 +0100	[thread overview]
Message-ID: <20170228192732.GA24218@kroah.com> (raw)
In-Reply-To: <20170228192619.GB22709@kroah.com>

On Tue, Feb 28, 2017 at 08:26:19PM +0100, Greg KH wrote:
> On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote:
> > This patch fixes warning of line over 80 characters, as issued by
> > checkpatch.pl
> > 
> > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> > ---
> > v2:
> >  - split multiple changes across different patches
> > v3:
> >  - mentioned patch revision in subject
> > v4:
> >  - modified description to exclude mention of patch number from changelog
> > v5:
> >  - updated series for removing additional checkpatch error introduced
> > 
> >  drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> > index 9ab80e1..668202d 100644
> > --- a/drivers/staging/ks7010/ks_wlan.h
> > +++ b/drivers/staging/ks7010/ks_wlan.h
> > @@ -18,10 +18,10 @@
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> >  
> > -#include <linux/spinlock.h>	/* spinlock_t                                   */
> > -#include <linux/sched.h>	/* wait_queue_head_t                            */
> > -#include <linux/types.h>	/* pid_t                                        */
> > -#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
> > +#include <linux/spinlock.h>	/* spinlock_t */
> > +#include <linux/sched.h>	/* wait_queue_head_t */
> > +#include <linux/types.h>	/* pid_t */
> > +#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
> >  #include <linux/etherdevice.h>
> >  #include <linux/wireless.h>
> >  #include <linux/atomic.h>	/* struct atomic_t */
> > @@ -36,7 +36,8 @@
> >  
> >  #ifdef KS_WLAN_DEBUG
> >  #define DPRINTK(n, fmt, args...) \
> > -                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> > +                 if (KS_WLAN_DEBUG > (n)) \
> 
> Why did you not use a tab here to indent this line as you were modifying
> it?

Oh nevermind, you change this up later on in the series...

  reply	other threads:[~2017-02-28 19:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26  6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi
2017-02-26  7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi
2017-02-27 14:46   ` Greg KH
2017-02-28  2:59     ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi
2017-02-28  3:00       ` [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi
2017-02-28  3:00       ` [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi
2017-02-28  3:01       ` [PATCH v5 4/5] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi
2017-02-28  3:01       ` [PATCH v5 5/5] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi
2017-02-28 19:26       ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH
2017-02-28 19:27         ` Greg KH [this message]
2017-02-26  7:01 ` [PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces Chetan Sethi
2017-02-26  7:02 ` [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi
2017-02-26  7:02 ` [PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi
2017-02-26  7:03 ` [PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228192732.GA24218@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cpsethi369@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=punitvara@gmail.com \
    --cc=shiva@exdev.nl \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox