From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org, tglx@linutronix.de,
jpoimboe@redhat.com, a.p.zijlstra@chello.nl,
torvalds@linux-foundation.org, peterz@infradead.org,
hpa@zytor.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size
Date: Wed, 1 Mar 2017 11:37:12 +0100 [thread overview]
Message-ID: <20170301103712.GA22478@gmail.com> (raw)
In-Reply-To: <tip-90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5@git.kernel.org>
* tip-bot for Josh Poimboeuf <tipbot@zytor.com> wrote:
> Commit-ID: 90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5
> Gitweb: http://git.kernel.org/tip/90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5
> Author: Josh Poimboeuf <jpoimboe@redhat.com>
> AuthorDate: Wed, 1 Mar 2017 00:05:04 -0600
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 1 Mar 2017 07:38:25 +0100
>
> objtool: Fix __unreachable section relocation size
>
> Linus reported the following commit broke module loading on his laptop:
>
> d1091c7fa3d5 ("objtool: Improve detection of BUG() and other dead ends")
>
> It showed errors like the following:
>
> module: overflow in relocation type 10 val ffffffffc02afc81
> module: 'nvme' likely not compiled with -mcmodel=kernel
BTW., beyond inadequate testing, another mistake I failed to notice during review
is that the title of the patch was actively misleading: an "objtool: " prefix
suggests a change that only affects objtool, while the changes here were to
compiler-gcc.h, affecting pretty much everyone...
So a better, more informative commit title would have been:
objtool, compiler.h: Improve detection of BUG() and other dead ends
... to at least warn people about the wider impact. (To be honest I personally
probably would still not have noticed the bug, but maybe others.)
Along the same lines I'll fix the title of this fix patch as well, once a final
version has been reached.
Thanks,
Ingo
next prev parent reply other threads:[~2017-03-01 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 7:53 [GIT PULL] objtool fixes Ingo Molnar
2017-03-01 1:55 ` Linus Torvalds
2017-03-01 6:05 ` Josh Poimboeuf
2017-03-01 8:10 ` [tip:core/urgent] objtool: Fix __unreachable section relocation size tip-bot for Josh Poimboeuf
2017-03-01 8:15 ` hpa
2017-03-01 12:41 ` Josh Poimboeuf
2017-03-01 12:44 ` [PATCH] objtool, compiler.h: " Ingo Molnar
2017-03-01 12:56 ` Josh Poimboeuf
2017-03-01 10:37 ` Ingo Molnar [this message]
2017-03-01 12:43 ` [tip:core/urgent] objtool: " Josh Poimboeuf
2017-03-01 12:45 ` [tip:core/urgent] objtool, compiler.h: " tip-bot for Josh Poimboeuf
2017-03-01 13:24 ` tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301103712.GA22478@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).