Re: [PATCH] netfilter: nf_conntrack_sip: fix wrong memory initialisation

Pablo Neira Ayuso
2017-03-03T13:04:39Z

On Wed, Mar 01, 2017 at 03:33:26PM +0100, Christophe Leroy wrote:
> In commit 82de0be6862cd ("netfilter: Add helper array
> register/unregister functions"),
> struct nf_conntrack_helper sip[MAX_PORTS][4] was changed to
> sip[MAX_PORTS * 4], so the memory init should have been changed to
> memset(&sip[4 * i], 0, 4 * sizeof(sip[i]));
>
> But as the sip[] table is allocated in the BSS, it is already set to 0

Applied, thanks.