From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751799AbdCAQr2 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Mar 2017 11:47:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22931 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751099AbdCAQrX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Mar 2017 11:47:23 -0500
Date: Wed, 1 Mar 2017 17:37:32 +0100
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        James Hogan <james.hogan@imgtec.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v2 1/5] KVM: rename API for requests to match bit
 operations
Message-ID: <20170301163731.GB20547@potion>
References: <20170224195002.28030-1-rkrcmar@redhat.com>
 <20170224195002.28030-2-rkrcmar@redhat.com>
 <69dff1a5-6af4-ce1e-bb5c-3e3adb1ee6ae@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <69dff1a5-6af4-ce1e-bb5c-3e3adb1ee6ae@redhat.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 01 Mar 2017 16:37:37 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-02-27 10:54+0100, David Hildenbrand:
> Am 24.02.2017 um 20:49 schrieb Radim Krčmář:
>> kvm_make_request was a wrapper that added barriers to set_bit and
>> kvm_check_request did the same for test_bit and check_bit, but the name
>> was not very obvious.
>> 
>> The renaming:
>>   kvm_request_set            <- kvm_make_request
>>   kvm_request_test_and_clear <- kvm_check_request
>> 
> 
> What about kvm_req_set() / kvm_req_test_and_clear()
> Matches the request bit definitions (KVM_REQ_*) and saves a couple of
> characters.

Good point.  I prefer to avoid abbreviations, but can be easily
convinced on this.

> Anyhow
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

I'll do nothing for now as it would just spin another round of reviews.

Thanks.