From: "Radim Krčmář" <rkrcmar@redhat.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Jones <drjones@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Paul Mackerras <paulus@ozlabs.org>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear
Date: Wed, 1 Mar 2017 18:04:04 +0100 [thread overview]
Message-ID: <20170301170403.GE20547@potion> (raw)
In-Reply-To: <20170228112903.GK996@jhogan-linux.le.imgtec.org>
2017-02-28 11:29+0000, James Hogan:
> On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
>> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
>> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
>> >> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> >> ---
>> >> arch/mips/kvm/emulate.c | 1 -
>> >> 1 file changed, 1 deletion(-)
>> >>
>> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
>> >> index 552ae2b5e911..70614ca41744 100644
>> >> --- a/arch/mips/kvm/emulate.c
>> >> +++ b/arch/mips/kvm/emulate.c
>> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
>> >> * check if any I/O interrupts are pending.
>> >> */
>> >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
>> >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
>> >> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
>> >> }
>> >
>> > should remove the {} too.
>> >
>>
>> With that,
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> and with that:
>
> Acked-by: James Hogan <james.hogan@imgtec.com>
I'll do that when applying or posting v3,
thanks for catching that.
next prev parent reply other threads:[~2017-03-01 17:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 19:49 [PATCH v2 0/5] KVM: rename and encapsulate vcpu->requests API Radim Krčmář
2017-02-24 19:49 ` [PATCH v2 1/5] KVM: rename API for requests to match bit operations Radim Krčmář
2017-02-27 9:54 ` David Hildenbrand
2017-03-01 16:37 ` Radim Krčmář
2017-02-24 19:49 ` [PATCH v2 2/5] KVM: add KVM request variants without barrier Radim Krčmář
2017-02-27 10:02 ` David Hildenbrand
2017-02-27 10:18 ` David Hildenbrand
2017-03-01 16:58 ` Radim Krčmář
2017-02-28 7:34 ` Peter Xu
2017-02-28 7:40 ` Peter Xu
2017-03-01 17:02 ` Radim Krčmář
2017-03-02 1:15 ` Peter Xu
2017-03-02 2:26 ` Peter Xu
2017-02-24 19:50 ` [PATCH v2 3/5] KVM: add kvm_request_pending Radim Krčmář
2017-02-27 10:02 ` David Hildenbrand
2017-02-24 19:50 ` [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Radim Krčmář
2017-02-27 8:45 ` Andrew Jones
2017-02-27 10:03 ` David Hildenbrand
2017-02-28 11:29 ` James Hogan
2017-03-01 17:04 ` Radim Krčmář [this message]
2017-02-24 19:50 ` [PATCH v2 5/5] KVM: optimize kvm_make_all_cpus_request Radim Krčmář
2017-02-27 8:47 ` [PATCH v2 0/5] KVM: rename and encapsulate vcpu->requests API Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301170403.GE20547@potion \
--to=rkrcmar@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).