From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753851AbdCBELe (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Mar 2017 23:11:34 -0500
Received: from mail.kernel.org ([198.145.29.136]:43638 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753075AbdCBEL0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Mar 2017 23:11:26 -0500
Date: Wed, 1 Mar 2017 17:26:06 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 2/4] perf tools: Introduce cpu_map__snprint_mask()
Message-ID: <20170301202606.GG15145@kernel.org>
References: <20170224011251.14946-1-namhyung@kernel.org>
 <20170224011251.14946-2-namhyung@kernel.org>
 <20170224210853.GB15145@kernel.org>
 <20170225042734.GA12723@danjae.aot.lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170225042734.GA12723@danjae.aot.lge.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sat, Feb 25, 2017 at 01:27:34PM +0900, Namhyung Kim escreveu:
> On Fri, Feb 24, 2017 at 06:08:53PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Feb 24, 2017 at 10:12:49AM +0900, Namhyung Kim escreveu:
> > util/cpumap.c:679:8: error: comparison is always true due to limited range of data type [-Werror=type-limits]
> >   if (0 <= val && val <= 9)
> >         ^~
> > Are you ok with the patch below?
 
> I'd rather change hex_char() instead.  How about this?

Ok, applying by hand, somehow it didn't apply using git-am...

- Arnaldo

> +++ b/tools/perf/util/cpumap.c
> @@ -674,11 +674,11 @@ size_t cpu_map__snprint(struct cpu_map *map, char *buf, size_t size)
>         return ret;
>  }
>  
> -static char hex_char(char val)
> +static char hex_char(unsigned char val)
>  {
> -       if (0 <= val && val <= 9)
> +       if (val < 10)
>                 return val + '0';
> -       if (10 <= val && val < 16)
> +       if (val < 16)
>                 return val - 10 + 'a';
>         return '?';
>  }