From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Sonny Rao <sonnyrao@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
tpmdd-devel@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH] tpm: do not suspend/resume if power stays on
Date: Wed, 1 Mar 2017 16:18:36 -0700 [thread overview]
Message-ID: <20170301231836.GE2820@obsidianresearch.com> (raw)
In-Reply-To: <CAPz6YkX=X+mZZRaiYrFGE0qyX1QC=wnXaA-PfvSozwfDM37h1w@mail.gmail.com>
On Wed, Mar 01, 2017 at 02:39:09PM -0800, Sonny Rao wrote:
> > We recently added global suspend/resume callbacks to the TPM
> > core. Those call backs do not power off the TPM, they just prepare its
> > internal state to loose power to the chip. Skipping that process on
> > hardware that does not power-off the TPM makes sense to me.
> >
> > But, Sonny, perhaps this should be a global flag in tpm_chip, not a
> > per-interface-driver override?
>
> It's a property of the board design not the chip -- maybe I'm
> misunderstanding?
I mean do not add the code to handle this to tpm_i2c_infineon.c but in
the common chip code instead.
tpm_i2c_infineon.c should only parse DT properties that are relavent
to the bus that delivers commands to the TPM, things that apply to how
a TPM chip operates should be handled in the core code because they
apply to any command transport bus.
Jason
next prev parent reply other threads:[~2017-03-02 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 11:51 [PATCH] tpm: do not suspend/resume if power stays on Enric Balletbo i Serra
2017-03-01 12:00 ` Peter Huewe
2017-03-01 12:08 ` Enric Balletbo i Serra
2017-03-01 13:54 ` Mark Rutland
2017-03-01 18:43 ` [tpmdd-devel] " Jason Gunthorpe
2017-03-01 22:39 ` Sonny Rao
2017-03-01 23:18 ` Jason Gunthorpe [this message]
2017-03-02 0:02 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301231836.GE2820@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox