From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbdCBWfi (ORCPT ); Thu, 2 Mar 2017 17:35:38 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39174 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbdCBWfg (ORCPT ); Thu, 2 Mar 2017 17:35:36 -0500 Date: Thu, 02 Mar 2017 14:34:06 -0800 (PST) Message-Id: <20170302.143406.1348849132445336690.davem@davemloft.net> To: dmitry.torokhov@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: net: ethernet: remove incorrect __exit markups From: David Miller In-Reply-To: <20170302012447.GA39241@dtor-ws> References: <20170302012447.GA39241@dtor-ws> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Mar 2017 14:34:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Torokhov Date: Wed, 1 Mar 2017 17:24:47 -0800 > Even if bus is not hot-pluggable, devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov Applied, thank you.