From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbdCBGk4 (ORCPT ); Thu, 2 Mar 2017 01:40:56 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35543 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753547AbdCBGkx (ORCPT ); Thu, 2 Mar 2017 01:40:53 -0500 Date: Thu, 2 Mar 2017 07:40:47 +0100 From: Ingo Molnar To: Lu Baolu Cc: Greg Kroah-Hartman , Ingo Molnar , Mathias Nyman , tglx@linutronix.de, peterz@infradead.org, linux-usb@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/5] usb: early: add support for early printk through USB3 debug port Message-ID: <20170302064047.GA23335@gmail.com> References: <1487039241-596-1-git-send-email-baolu.lu@linux.intel.com> <58B7809E.4020108@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58B7809E.4020108@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lu Baolu wrote: > Hi Ingo, > > How about this version? Any further comments? So I have re-read the review feedback I gave on Jan 19 and found at least one thing I pointed out that you didn't address in the latest patches ... Plus please go beyond the feedback given - for example the Kconfig text contains at least one typo. Thanks, Ingo