From: Minchan Kim <minchan@kernel.org>
To: Sangwoo <sangwoo2.park@lge.com>
Cc: ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zram: reduce load operation in page_same_filled
Date: Thu, 2 Mar 2017 16:02:47 +0900 [thread overview]
Message-ID: <20170302070247.GA32617@bbox> (raw)
In-Reply-To: <1488428104-7257-1-git-send-email-sangwoo2.park@lge.com>
Hi Sangwoo,
On Thu, Mar 02, 2017 at 01:15:04PM +0900, Sangwoo wrote:
> In page_same_filled function, all elements in the page is compared
> with next index value. The current comparison routine compares
> the (i)th and (i+1)th values of the page.
> In this case, two load operaions occur for each comparison.
> But if we store first value of the page stores at 'val' variable
> and using it to compare with others, the load opearation is reduced.
> It reduce load operation per page by up to 64times.
>
> Signed-off-by: Sangwoo <sangwoo2.park@lge.com>
The rule is that you should use your full name Sangwoo Park for SOB. :)
Anyway, Good spot!
FYI,
Ccing Andrew because he merges zram patches to mmotm tree.
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
next prev parent reply other threads:[~2017-03-02 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 4:15 [PATCH] zram: reduce load operation in page_same_filled Sangwoo
2017-03-02 7:02 ` Minchan Kim [this message]
2017-03-02 7:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302070247.GA32617@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sangwoo2.park@lge.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).