From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754138AbdCBIJa (ORCPT ); Thu, 2 Mar 2017 03:09:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004AbdCBIJ1 (ORCPT ); Thu, 2 Mar 2017 03:09:27 -0500 Date: Thu, 2 Mar 2017 09:08:58 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Borislav Petkov , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Adrian Hunter , lkml , Ingo Molnar , David Ahern Subject: Re: [PATCHv2] perf tools: Force uncore events to system wide monitoring Message-ID: <20170302080858.GB24099@krava> References: <20170227094413.cdm63spdgphj2x5b@pd.tnic> <20170227094818.GA12764@krava> <20170301213639.GO15145@kernel.org> <20170302074410.GA24099@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170302074410.GA24099@krava> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 02 Mar 2017 08:09:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 02, 2017 at 08:44:10AM +0100, Jiri Olsa wrote: > On Wed, Mar 01, 2017 at 06:36:39PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > [acme@jouet linux]$ perf stat usleep 1 > > > > Performance counter stats for 'usleep 1': > > > > 2.022049 task-clock:u (msec) # 0.181 CPUs utilized > > 0 context-switches:u # 0.000 K/sec > > 0 cpu-migrations:u # 0.000 K/sec > > 48 page-faults:u # 0.024 M/sec > > 2,177,301 cycles:u # 1.077 GHz > > 245,106 instructions:u # 0.11 insn per cycle > > 48,000 branches:u # 23.738 M/sec > > 3,936 branch-misses:u # 8.20% of all branches > > > > 0.011181563 seconds time elapsed > > > > [acme@jouet linux]$ > > > > --------------------------------------------- > > > > Seems related to the auto :u done when the user can't do kernel profiling, etc. > > > > Re-applying your patch, to triple check: > > > > [acme@jouet linux]$ perf stat usleep 1 2>&1 | head -2 > > Error: > > You may not have permission to collect system-wide stats. > > [acme@jouet linux]$ > > > > ------------------------------------------------ > > > > Waiting for v3 :-) > > oh my... I'll check could you please try with attched change thanks, jirka --- diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 1320352cda04..f53f449d864d 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2374,7 +2374,8 @@ static void setup_system_wide(int forks) return; } - target.system_wide = true; + if (evsel_list->nr_entries) + target.system_wide = true; } }