From: Stephen Hemminger <stephen@networkplumber.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: devel@linuxdriverproject.org,
Stephen Hemminger <sthemmin@microsoft.com>,
Alex Ng <alexng@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself
Date: Thu, 2 Mar 2017 08:53:21 -0800 [thread overview]
Message-ID: <20170302085321.6dcf4a36@xeon-e3> (raw)
In-Reply-To: <20170302094749.3097-1-vkuznets@redhat.com>
On Thu, 2 Mar 2017 10:47:49 +0100
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> Waiting for release_event in all three drivers introduced issues on release
> as on_reset() hook is not always called. E.g. if the device was never
> opened we will never get the completion.
>
> Move the waiting code to hvutil_transport_destroy() and make sure it is
> only called when the device is open. hvt->lock serialization should
> guarantee the absence of races.
>
> Fixes: 5a66fecbf6aa ("Drivers: hv: util: kvp: Fix a rescind processing issue")
> Fixes: 20951c7535b5 ("Drivers: hv: util: Fcopy: Fix a rescind processing issue")
> Fixes: d77044d142e9 ("Drivers: hv: util: Backup: Fix a rescind processing issue")
> Reported-by: Dexuan Cui <decui@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: Stephen Hemminger <sthemmin@microsoft.com>
prev parent reply other threads:[~2017-03-02 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 9:47 [PATCH] Drivers: hv: util: move waiting for release to hv_utils_transport itself Vitaly Kuznetsov
2017-03-02 10:06 ` Dexuan Cui
2017-03-02 16:53 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302085321.6dcf4a36@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexng@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox