From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbdCCBPG (ORCPT ); Thu, 2 Mar 2017 20:15:06 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:52714 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbdCCBPC (ORCPT ); Thu, 2 Mar 2017 20:15:02 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Fri, 3 Mar 2017 10:14:47 +0900 From: Namhyung Kim To: Steven Rostedt Cc: Todd Brandt , linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: ftrace_graph_filter not working correctly since v4.10 Message-ID: <20170303011447.GI30710@sejong> References: <1488420091.7212.17.camel@linux.intel.com> <20170301222843.6ea73495@grimm.local.home> <20170301224730.2af14888@grimm.local.home> <20170302124940.19088e85@gandalf.local.home> <20170302130551.4ed29006@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170302130551.4ed29006@gandalf.local.home> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 02, 2017 at 01:05:51PM -0500, Steven Rostedt wrote: > > Namhyung, > > Just an FYI... Thanks, Steve. I'll do more testing next time.. Namhyung > > > On Thu, 2 Mar 2017 12:49:40 -0500 > Steven Rostedt wrote: > > > On Wed, 1 Mar 2017 22:47:30 -0500 > > Steven Rostedt wrote: > > > > > On Wed, 1 Mar 2017 22:28:43 -0500 > > > Steven Rostedt wrote: > > > > > > > > 4.10 is fine. It's what has been merged for 4.11 that's broken. I'm > > > > doing a bisect now to see what broke it. Yes, lots of commits touched > > > > that code recently. > > > > > > I found the bad commit. I'll have a patch for you to test tomorrow. > > > > > > > Can you test this patch please. > > > > -- Steve > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index 2d554a0..1b33a41 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -4403,10 +4403,9 @@ static void __init set_ftrace_early_graph(char *buf, int enable) > > char *func; > > struct ftrace_hash *hash; > > > > - if (enable) > > - hash = ftrace_graph_hash; > > - else > > - hash = ftrace_graph_notrace_hash; > > + hash = alloc_ftrace_hash(FTRACE_HASH_DEFAULT_BITS); > > + if (WARN_ON(!hash)) > > + return; > > > > while (buf) { > > func = strsep(&buf, ","); > > @@ -4416,6 +4415,11 @@ static void __init set_ftrace_early_graph(char *buf, int enable) > > printk(KERN_DEBUG "ftrace: function %s not " > > "traceable\n", func); > > } > > + > > + if (enable) > > + ftrace_graph_hash = hash; > > + else > > + ftrace_graph_notrace_hash = hash; > > } > > #endif /* CONFIG_FUNCTION_GRAPH_TRACER */ > > >