From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values
Date: Fri, 3 Mar 2017 11:33:03 +0100 [thread overview]
Message-ID: <20170303103303.GA8905@krava> (raw)
In-Reply-To: <20170301064924.32172-2-andi@firstfloor.org>
On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote:
SNIP
> +static void collect_data(struct perf_evsel *counter,
> + void (*cb)(struct perf_evsel *counter, void *data,
> + bool first),
> + void *data)
> +{
> + cb(counter, data, true);
> +}
> +
> +struct aggr_data {
> + u64 ena, run, val;
> + int id;
> + int nr;
> + int cpu;
> +};
> +
> +static void aggr_cb(struct perf_evsel *counter, void *data, bool first)
> +{
> + struct aggr_data *ad = data;
> + int cpu, cpu2, s2;
> +
> + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) {
> + struct perf_counts_values *counts;
> +
> + cpu2 = perf_evsel__cpus(counter)->map[cpu];
> + s2 = aggr_get_id(evsel_list->cpus, cpu2);
that does not match the removed code.. why?
s2 = aggr_get_id(perf_evsel__cpus(counter), cpu);
jirka
next prev parent reply other threads:[~2017-03-03 10:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 6:49 perf: Improve support for uncore JSON event lists Andi Kleen
2017-03-01 6:49 ` [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values Andi Kleen
2017-03-03 10:33 ` Jiri Olsa [this message]
2017-03-03 23:16 ` Andi Kleen
2017-03-05 17:01 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 02/10] perf, tools, stat: Collapse identically named events Andi Kleen
2017-03-05 17:55 ` Jiri Olsa
2017-03-07 10:02 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 03/10] perf, tools: Factor out PMU matching in parser Andi Kleen
2017-03-07 10:03 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 04/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-03-01 6:49 ` [PATCH 05/10] perf, tools: Special case uncore_ prefix Andi Kleen
2017-03-01 6:49 ` [PATCH 06/10] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-03-01 6:49 ` [PATCH 07/10] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-03-01 6:49 ` [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-03-07 10:03 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 09/10] perf, tools, list: Support printing MetricExpr with -v Andi Kleen
2017-03-01 6:49 ` [PATCH 10/10] perf, tools: Add support for MetricName JSON attribute Andi Kleen
2017-03-07 10:03 ` Jiri Olsa
2017-03-07 10:04 ` perf: Improve support for uncore JSON event lists Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-02-24 0:10 [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values Andi Kleen
2017-02-24 8:37 ` Jiri Olsa
2017-02-24 15:29 ` Andi Kleen
2017-02-26 23:28 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303103303.GA8905@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).