From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751875AbdCCKmA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Mar 2017 05:42:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59044 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751568AbdCCKlA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Mar 2017 05:41:00 -0500
Date: Fri, 3 Mar 2017 11:33:03 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools, stat: Factor out callback for
 collecting event values
Message-ID: <20170303103303.GA8905@krava>
References: <20170301064924.32172-1-andi@firstfloor.org>
 <20170301064924.32172-2-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170301064924.32172-2-andi@firstfloor.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 03 Mar 2017 10:33:06 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote:

SNIP

> +static void collect_data(struct perf_evsel *counter,
> +			    void (*cb)(struct perf_evsel *counter, void *data,
> +				       bool first),
> +			    void *data)
> +{
> +	cb(counter, data, true);
> +}
> +
> +struct aggr_data {
> +	u64 ena, run, val;
> +	int id;
> +	int nr;
> +	int cpu;
> +};
> +
> +static void aggr_cb(struct perf_evsel *counter, void *data, bool first)
> +{
> +	struct aggr_data *ad = data;
> +	int cpu, cpu2, s2;
> +
> +	for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) {
> +		struct perf_counts_values *counts;
> +
> +		cpu2 = perf_evsel__cpus(counter)->map[cpu];
> +		s2 = aggr_get_id(evsel_list->cpus, cpu2);

that does not match the removed code.. why?
                s2 = aggr_get_id(perf_evsel__cpus(counter), cpu);

jirka