From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adrien Descamps <adrien.descamps@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix endiannes error
Date: Fri, 3 Mar 2017 14:29:07 +0300 [thread overview]
Message-ID: <20170303112621.GC4132@mwanda> (raw)
In-Reply-To: <1488486612-2969-2-git-send-email-adrien.descamps@gmail.com>
These patches look good but you need to resend with a correct subsystem
prefix in the subject. It should be:
[PATCH 2/2] Staging: wlan-ng: Fix endiannes error
Hm... Also "endiannes" doesn't look like correct spelling. Just say
"endian".
On Thu, Mar 02, 2017 at 09:30:12PM +0100, Adrien Descamps wrote:
> sparse report fixed:
> drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer
> drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types)
> drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: expected restricted __be64 [usertype] mactime
> drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: got unsigned long long
>
> Computation on the value should be done when in machine format, not in big endian format.
> Compile tested only.
Generally we like to put the "Compile tested only" bit under the ---
cut off so that our patches look more confident and authoritative. ;)
>
> Signed-off-by: Adrien Descamps <adrien.descamps@gmail.com>
> ---
Put it here.
> drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-03 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 20:30 [PATCH 1/2] Fix sparse warnings by using appropriate endian types Adrien Descamps
2017-03-02 20:30 ` [PATCH 2/2] Fix endiannes error Adrien Descamps
2017-03-03 11:29 ` Dan Carpenter [this message]
2017-03-03 18:58 ` [PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types Adrien Descamps
2017-03-03 18:58 ` [PATCH 2/2] Staging: wlan-ng: Fix endian error Adrien Descamps
2017-03-09 18:05 ` [PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types Greg KH
2017-03-09 20:15 ` Adrien Descamps
2017-03-09 20:15 ` [PATCH 2/2] Staging: wlan-ng: Fix endian error Adrien Descamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303112621.GC4132@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adrien.descamps@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox