From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751948AbdCCNEj (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Mar 2017 08:04:39 -0500
Received: from mail.us.es ([193.147.175.20]:39454 "EHLO mail.us.es"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751860AbdCCNEg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Mar 2017 08:04:36 -0500
Date: Fri, 3 Mar 2017 13:27:18 +0100
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        "David S. Miller" <davem@davemloft.net>,
        Gao Feng <fgao@48lvckh6395k16k5.yundunddos.com>,
        linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org, netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix wrong memory
 initialisation
Message-ID: <20170303122718.GA15498@salvia>
References: <20170301143327.2C90B6BD30@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170301143327.2C90B6BD30@localhost.localdomain>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 01, 2017 at 03:33:26PM +0100, Christophe Leroy wrote:
> In commit 82de0be6862cd ("netfilter: Add helper array
> register/unregister functions"),
> struct nf_conntrack_helper sip[MAX_PORTS][4] was changed to
> sip[MAX_PORTS * 4], so the memory init should have been changed to
> memset(&sip[4 * i], 0, 4 * sizeof(sip[i]));
> 
> But as the sip[] table is allocated in the BSS, it is already set to 0

Applied, thanks.