Re: [PATCH v5 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support

Jonathan Cameron
2017-03-02T20:10:27Z

On 02/03/17 03:02, Eva Rachel Retuya wrote:
> On Thu, Mar 02, 2017 at 01:22:11AM +0200, Andy Shevchenko wrote:
>> On Tue, Feb 28, 2017 at 4:37 AM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
>>> This patchset modifies the adxl345 to use regmap. In doing so, we can
>>> easily introduce SPI support and let regmap handle the rest.
>>>
>>> Recap of basic features: read_raw for x, y and z axes, scale. After
>>> applying this series, driver now supports the SPI protocol and enumeration
>>> of device via device tree.
>>
>> If I knew you are going to send new version I would have commented on v4...
>>
>
> Hi Andy,
>
> Please state your comments and I will submit a new revision.
>
> Thanks,
> Eva
Looks good to me so I'll probably pick this up over the weekend unless you want
to make a V6 with anything from Andy. Can always send follow up patches later
for any issues highlighted.

Ideally we 'might' have devicetree ack by then, but given you have fixed
the one issue raised in the review, I may not wait for that (can add it in the
week it'll inevitably sit in my testing branch for!)

Jonathan
>
>>>
>>> Changes from v4:
>>> [PATCH 1/4]
>>> * Update subject-prefix
>>> * Update node name from "adxl345@unit-address" to "accelerometer@unit-address"
>>> Patches 2-4
>>> * Add Andy's Reviewed-by tag
>>>
>>> Changes from v3:
>>> [PATCH 1/4]
>>> * None
>>> [PATCH 2/4]
>>> * Keep intact I2C client structure which was deleted from v3
>>> * Make use of regmap_get_device to retrieve struct device, use these for
>>> debugging prints instead of &client->dev.
>>> [PATCH 3/4] and [PATCH 4/4]
>>> * Revert to explicit and separate I2C and SPI configuration
>>> * Add OF match table, make it enumerable in ACPI environment (Andy's suggestion)
>>>
>>> Changes from v2:
>>> * Drop PATCH 4 iio: accel: adxl345: Add ACPI support
>>> * Add OF match table on both I2C and SPI files and document them
>>>
>>> Changes from v1:
>>> [PATCH 1/4]
>>> * Move other deletions from patch 2 in here -- make it clear what got deleted
>>> and/or modified that is hard to see previously
>>> * Introduce the driver header file "adxl345.h" here instead of doing it in the
>>> next patch
>>> * Completely omit traces of i2c_client and let this file (adxl345.c) mirror the
>>> core file on the next patch.
>>> * Improve debugging print about invalid device ID in probe.
>>> [PATCH 2/4]
>>> * Update Kconfig to Jonathan's preferred style
>>> * Improve similarity index from 78% to 100% (rename detection)
>>> [PATCH 4/4]
>>> * Correct acpi_device_id: ADX0345 -> ADS0345
>>>
>>> Eva Rachel Retuya (4):
>>> dt-bindings: iio: accel: Document ADXL345 accelerometer binding
>>> iio: accel: adxl345: Use I2C regmap instead of direct I2C access
>>> iio: accel: adxl345: Split driver into core and I2C
>>> iio: accel: adxl345: Add SPI support
>>>
>>> .../devicetree/bindings/iio/accel/adxl345.txt | 38 +++++++++
>>> drivers/iio/accel/Kconfig | 26 ++++++-
>>> drivers/iio/accel/Makefile | 4 +-
>>> drivers/iio/accel/adxl345.h | 18 +++++
>>> drivers/iio/accel/{adxl345.c => adxl345_core.c} | 89 +++++++++-------------
>>> drivers/iio/accel/adxl345_i2c.c | 78 +++++++++++++++++++
>>> drivers/iio/accel/adxl345_spi.c | 83 ++++++++++++++++++++
>>> 7 files changed, 281 insertions(+), 55 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/iio/accel/adxl345.txt
>>> create mode 100644 drivers/iio/accel/adxl345.h
>>> rename drivers/iio/accel/{adxl345.c => adxl345_core.c} (62%)
>>> create mode 100644 drivers/iio/accel/adxl345_i2c.c
>>> create mode 100644 drivers/iio/accel/adxl345_spi.c
>>>
>>> --
>>> 2.7.4
>>>
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko