From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdCDGtd (ORCPT ); Sat, 4 Mar 2017 01:49:33 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35560 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdCDGtc (ORCPT ); Sat, 4 Mar 2017 01:49:32 -0500 Date: Sat, 4 Mar 2017 08:49:28 +0200 From: Ernestas Kulik To: Joe Perches , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: clean up code Message-ID: <20170304064927.GA4470@gmail.com> References: <20170303205836.32557-1-ernestas.kulik@gmail.com> <1488590630.2179.41.camel@perches.com> <20170304062858.GA2120@gmail.com> <1488609447.2179.47.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488609447.2179.47.camel@perches.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > struct hostif_hdr.event is declared at uint16_t > and not as __le16 so I believe this is incorrect > and actually introduces a sparse error. Sure, but I change that in the patch. :) On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote: > > struct hostif_hdr { >- uint16_t size; >- uint16_t event; >+ __le16 size; >+ __le16 event; > } __packed;