From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbdCDOnB (ORCPT ); Sat, 4 Mar 2017 09:43:01 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:51127 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbdCDOnA (ORCPT ); Sat, 4 Mar 2017 09:43:00 -0500 Date: Sat, 4 Mar 2017 17:42:17 +0300 From: Dan Carpenter To: Ernestas Kulik Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: ks7010: fix sparse warnings Message-ID: <20170304144216.GE4386@mwanda> References: <20170304085623.32674-1-ernestas.kulik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170304085623.32674-1-ernestas.kulik@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 04, 2017 at 10:56:23AM +0200, Ernestas Kulik wrote: > Currently, sparse generates many warnings for the driver. This commit > changes the types of struct fields/function variables to match the > endianness at their assignment. > > Signed-off-by: Ernestas Kulik > --- > Changes from v1: > * Change the type of the variable being passed to ntohs() instead of casting it > * Don’t remove any struct fields [ snip ] > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 6f9f746a3a61..8e644ff8eca8 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -297,7 +297,8 @@ static int write_to_device(struct ks_wlan_private *priv, unsigned char *buffer, > hdr = (struct hostif_hdr *)buffer; > > DPRINTK(4, "size=%d\n", hdr->size); > - if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event) { > + if (le16_to_cpu(hdr->event) < HIF_DATA_REQ || > + HIF_REQ_MAX < le16_to_cpu(hdr->event)) { Don't mix cleanups and bugfixes. They have to be done in separate patches. Also this change wasn't described in the changelog like Joe explained. regards, dan carpenter