From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbdCENaM (ORCPT ); Sun, 5 Mar 2017 08:30:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbdCENaL (ORCPT ); Sun, 5 Mar 2017 08:30:11 -0500 From: Jeff Layton To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/1] mm: fix mapping_set_error call in me_pagecache_dirty Date: Sun, 5 Mar 2017 08:20:02 -0500 Message-Id: <20170305132002.5582-1-jlayton@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Sun, 05 Mar 2017 13:20:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code should be negative. Since this ends up in the default case anyway, this is harmless, but it's less confusing to negate it. Signed-off-by: Jeff Layton --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index f283c7e0a2a3..f6512c953f9b 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -673,7 +673,7 @@ static int me_pagecache_dirty(struct page *p, unsigned long pfn) * the first EIO, but we're not worse than other parts * of the kernel. */ - mapping_set_error(mapping, EIO); + mapping_set_error(mapping, -EIO); } return me_pagecache_clean(p, pfn); -- 2.9.3