From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbdCERz5 (ORCPT ); Sun, 5 Mar 2017 12:55:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbdCERz4 (ORCPT ); Sun, 5 Mar 2017 12:55:56 -0500 Date: Sun, 5 Mar 2017 18:55:42 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events Message-ID: <20170305175542.GC20686@krava> References: <20170301064924.32172-1-andi@firstfloor.org> <20170301064924.32172-3-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301064924.32172-3-andi@firstfloor.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 05 Mar 2017 17:55:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:49:16PM -0800, Andi Kleen wrote: SNIP > > struct aggr_data { > @@ -1208,6 +1231,16 @@ static void aggr_cb(struct perf_evsel *counter, void *data, bool first) > if (first) > ad->nr++; > counts = perf_counts(counter->counts, cpu, 0); > + /* > + * When any result is bad, make them all to give > + * consistent output in interval mode. > + */ > + if (counts->ena == 0 || counts->run == 0 || > + counter->counts->scaled == -1) { > + ad->ena = 0; > + ad->run = 0; > + break; > + } I think this needs to be in separate patch, showing the interval output before and after the change.. thanks, jirka