From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Stenglein <mark@stengle.in>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
Date: Mon, 6 Mar 2017 07:53:38 +0100 [thread overview]
Message-ID: <20170306065338.GA31202@kroah.com> (raw)
In-Reply-To: <20170306020912.21046-1-mark@stengle.in>
On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.
What issue would that be?
> Signed-off-by: Mark Stenglein <mark@stengle.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
What is wrong with the original code here?
Please don't blindly trust checkpatch.pl all the time, sometimes you
have to use your brain when reading the results.
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-06 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 2:09 [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein
2017-03-06 6:53 ` Greg KH [this message]
2017-03-07 17:31 ` Dan Carpenter
2017-03-07 17:36 ` Mark Stenglein
2017-03-07 17:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306065338.GA31202@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@stengle.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox