From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbdCFG45 (ORCPT ); Mon, 6 Mar 2017 01:56:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51722 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbdCFGyx (ORCPT ); Mon, 6 Mar 2017 01:54:53 -0500 Date: Mon, 6 Mar 2017 07:53:38 +0100 From: Greg KH To: Mark Stenglein Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Message-ID: <20170306065338.GA31202@kroah.com> References: <20170306020912.21046-1-mark@stengle.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170306020912.21046-1-mark@stengle.in> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote: > Fixed a coding style issue. What issue would that be? > Signed-off-by: Mark Stenglein > --- > drivers/staging/wlan-ng/hfa384x.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > index 5f1851c85f12..f19984747b1e 100644 > --- a/drivers/staging/wlan-ng/hfa384x.h > +++ b/drivers/staging/wlan-ng/hfa384x.h > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx { > enum ctlx_state state; /* Tracks running state */ > > struct completion done; > + > volatile int reapable; /* Food for the reaper task */ What is wrong with the original code here? Please don't blindly trust checkpatch.pl all the time, sometimes you have to use your brain when reading the results. thanks, greg k-h