* [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
@ 2017-03-06 2:09 Mark Stenglein
2017-03-06 6:53 ` Greg KH
2017-03-07 17:31 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Mark Stenglein @ 2017-03-06 2:09 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Mark Stenglein
Fixed a coding style issue.
Signed-off-by: Mark Stenglein <mark@stengle.in>
---
drivers/staging/wlan-ng/hfa384x.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5f1851c85f12..f19984747b1e 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
enum ctlx_state state; /* Tracks running state */
struct completion done;
+
volatile int reapable; /* Food for the reaper task */
ctlx_cmdcb_t cmdcb; /* Async command callback */
--
2.12.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
2017-03-06 2:09 [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein
@ 2017-03-06 6:53 ` Greg KH
2017-03-07 17:31 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2017-03-06 6:53 UTC (permalink / raw)
To: Mark Stenglein; +Cc: devel, linux-kernel
On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.
What issue would that be?
> Signed-off-by: Mark Stenglein <mark@stengle.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
What is wrong with the original code here?
Please don't blindly trust checkpatch.pl all the time, sometimes you
have to use your brain when reading the results.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
2017-03-06 2:09 [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein
2017-03-06 6:53 ` Greg KH
@ 2017-03-07 17:31 ` Dan Carpenter
2017-03-07 17:36 ` Mark Stenglein
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-03-07 17:31 UTC (permalink / raw)
To: Mark Stenglein; +Cc: gregkh, devel, linux-kernel
On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Mark Stenglein <mark@stengle.in>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c85f12..f19984747b1e 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> enum ctlx_state state; /* Tracks running state */
>
> struct completion done;
> +
> volatile int reapable; /* Food for the reaper task */
No blank line needed. The original is OK. (Except for the volatile is
wrong obviously).
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
2017-03-07 17:31 ` Dan Carpenter
@ 2017-03-07 17:36 ` Mark Stenglein
2017-03-07 17:40 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Mark Stenglein @ 2017-03-07 17:36 UTC (permalink / raw)
To: Dan Carpenter; +Cc: gregkh, devel, linux-kernel
All,
Thanks for the feedback. Trying to introduce myself and in retrospect
this seems to be a fairly non-productive way to go about it. Apologies
for any time lost.
Best,
Mark Stenglein
On Tue, Mar 07, 2017 at 08:31:13PM +0300, Dan Carpenter wrote:
> On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Mark Stenglein <mark@stengle.in>
> > ---
> > drivers/staging/wlan-ng/hfa384x.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c85f12..f19984747b1e 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> > enum ctlx_state state; /* Tracks running state */
> >
> > struct completion done;
> > +
> > volatile int reapable; /* Food for the reaper task */
>
> No blank line needed. The original is OK. (Except for the volatile is
> wrong obviously).
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
2017-03-07 17:36 ` Mark Stenglein
@ 2017-03-07 17:40 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2017-03-07 17:40 UTC (permalink / raw)
To: Mark Stenglein; +Cc: gregkh, devel, linux-kernel
On Tue, Mar 07, 2017 at 12:36:46PM -0500, Mark Stenglein wrote:
> All,
>
> Thanks for the feedback. Trying to introduce myself and in retrospect
> this seems to be a fairly non-productive way to go about it. Apologies
> for any time lost.
>
It's fine. I'm just rushing through patches as fast as possible. It
doesn't take any time.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-07 19:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-06 2:09 [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein
2017-03-06 6:53 ` Greg KH
2017-03-07 17:31 ` Dan Carpenter
2017-03-07 17:36 ` Mark Stenglein
2017-03-07 17:40 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox