From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932478AbdCFOpe (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Mar 2017 09:45:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35052 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932078AbdCFOeR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Mar 2017 09:34:17 -0500
Date: Mon, 6 Mar 2017 14:39:58 +0100
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Jiri Kosina <jikos@kernel.org>,
        Peter Hutterer <peter.hutterer@who-t.net>,
        Nestor Lopez Casado <nlopezcasad@logitech.com>,
        Olivier Gay <ogay@logitech.com>, Simon Wood <simon@mungewell.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in
 power_supply
Message-ID: <20170306133958.GY7064@mail.corp.redhat.com>
References: <20170202141229.17322-1-benjamin.tissoires@redhat.com>
 <20170202141229.17322-6-benjamin.tissoires@redhat.com>
 <1486134491.2316.11.camel@hadess.net>
 <20170207083557.GD16529@mail.corp.redhat.com>
 <alpine.LSU.2.20.1703061317480.31814@cbobk.fhfr.pm>
 <1488803268.28315.4.camel@hadess.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1488803268.28315.4.camel@hadess.net>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 06 Mar 2017 13:40:07 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mar 06 2017 or thereabouts, Bastien Nocera wrote:
> On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote:
> > On Tue, 7 Feb 2017, Benjamin Tissoires wrote:
> > 
> > > > > +               case POWER_SUPPLY_PROP_MANUFACTURER:
> > > > > +                       val->strval = "Logitech, Inc.";
> > > > 
> > > > I don't like this change. I'd prefer the concatenated
> > > > manufacturer and
> > > > model strings leading to user-friendly strings, and "Logitech
> > > > T650" is
> > > > better than "Logitech, Inc. T650".
> > > 
> > > Is this the only problematic issue? We are at rc7 already so I
> > > would
> > > like to have the final version ready ASAP.
> > 
> > Bastien, do you have any input on the rest of the series please?
> 
> My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove
> overloads and provide ONLINE" is the blocker.
> 
> No particular comments about the rest of the series.

Yes, sorry, this is still on my plate. I'll send out a revised series
soon hopefully.

Cheers,
Benjamin