From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519AbdCFVhG (ORCPT ); Mon, 6 Mar 2017 16:37:06 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34394 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932316AbdCFVgt (ORCPT ); Mon, 6 Mar 2017 16:36:49 -0500 Date: Mon, 6 Mar 2017 21:09:36 +0000 From: Oscar Campos To: Jiri Kosina Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] HID: Corsair Scimitar Pro RGB gaming mouse driver and support for other Corsair devices Message-ID: <20170306210935.GA9056@ArchStation> References: <20170210182234.GA18830@ManjaroStation> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2017 at 01:55:21PM +0100, Jiri Kosina wrote: > On Fri, 10 Feb 2017, Oscar Campos wrote: > > > Since I have a Corsair Scimitar PRO RGB that does not works on Linux, I > > tried to find a solution doing some research but was not able to find any. > [ ... snip ... ] > > > > I created the new mouse driver instead of add code to the already existent > > `hid-corsair.c` as it seem quite common to split mouse and keyboard driver > > support. > > Hi Oscar, > > thanks a lot for the patch. > > Keeping the support in hid-corsair would be prefered. I think the only > driver where we have the major kbd/mouse split is Holtek, which if I > remember correctly was my fault not having catched this during review; it > should probably eventually be unified. > > Otherwsie, we don't really distinguish the device type (the HID land is > much wider than mice and keyboards anyway), but in most cases by the > vendor. > > Could you please resubmit the patch so that it's actually adding changes > to hid-corsair? Thanks! I did send a [PATCH v2 2/2] that adds the changes to hid-corsair and rollback any uneeded changes into the Kconfig and Makefile files. I also added the vendor/product_id into the hid_have_special_driver[] array as suggested. > > -- > Jiri Kosina > SUSE Labs > Regards