From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 03/10] perf, tools: Factor out PMU matching in parser
Date: Tue, 7 Mar 2017 11:03:00 +0100 [thread overview]
Message-ID: <20170307100300.GB12093@krava> (raw)
In-Reply-To: <20170301064924.32172-4-andi@firstfloor.org>
On Tue, Feb 28, 2017 at 10:49:17PM -0800, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index a14b47ab3879..6b2bc918fc94 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -236,37 +236,9 @@ PE_NAME opt_event_config
> |
> PE_KERNEL_PMU_EVENT sep_dc
> {
> - struct parse_events_evlist *data = _data;
> - struct list_head *head;
> - struct parse_events_term *term;
> struct list_head *list;
> - struct perf_pmu *pmu = NULL;
> - int ok = 0;
>
> - /* Add it for all PMUs that support the alias */
> - ALLOC_LIST(list);
> - while ((pmu = perf_pmu__scan(pmu)) != NULL) {
> - struct perf_pmu_alias *alias;
> -
> - list_for_each_entry(alias, &pmu->aliases, list) {
> - if (!strcasecmp(alias->name, $1)) {
> - ALLOC_LIST(head);
> - ABORT_ON(parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
> - $1, 1, &@1, NULL));
> - list_add_tail(&term->list, head);
http://marc.info/?l=linux-kernel&m=148818456131560&w=2
jirka
next prev parent reply other threads:[~2017-03-07 10:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 6:49 perf: Improve support for uncore JSON event lists Andi Kleen
2017-03-01 6:49 ` [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values Andi Kleen
2017-03-03 10:33 ` Jiri Olsa
2017-03-03 23:16 ` Andi Kleen
2017-03-05 17:01 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 02/10] perf, tools, stat: Collapse identically named events Andi Kleen
2017-03-05 17:55 ` Jiri Olsa
2017-03-07 10:02 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 03/10] perf, tools: Factor out PMU matching in parser Andi Kleen
2017-03-07 10:03 ` Jiri Olsa [this message]
2017-03-01 6:49 ` [PATCH 04/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-03-01 6:49 ` [PATCH 05/10] perf, tools: Special case uncore_ prefix Andi Kleen
2017-03-01 6:49 ` [PATCH 06/10] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-03-01 6:49 ` [PATCH 07/10] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-03-01 6:49 ` [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-03-07 10:03 ` Jiri Olsa
2017-03-01 6:49 ` [PATCH 09/10] perf, tools, list: Support printing MetricExpr with -v Andi Kleen
2017-03-01 6:49 ` [PATCH 10/10] perf, tools: Add support for MetricName JSON attribute Andi Kleen
2017-03-07 10:03 ` Jiri Olsa
2017-03-07 10:04 ` perf: Improve support for uncore JSON event lists Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-02-24 0:10 [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values Andi Kleen
2017-02-24 0:10 ` [PATCH 03/10] perf, tools: Factor out PMU matching in parser Andi Kleen
2017-02-27 8:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307100300.GB12093@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox