Question about hwmon_attr_show_string

Peter Hüwe
2017-03-06T20:48:58Z

Hi Guenter,

I was wondering whether there was a particular reason why
hwmon_attr_show_string passes only an "empty" pointer(pointer) to the ops-
>read_string function rather than the buffer itself?

Wouldn't this mean that in ops->read_string I'd have to reserve some space for
the value on the heap (and taking care to free it somewhere, since returning
an address on the stack is bad idea), instead of calling sprintf(buf, "%s\n",
s) directly?

With the current implementation I have to sprintf it into my local buffer and
you sprintf it again into the final buffer.

Unfortunately there are no other callers, where you show the intended usage.

Thanks,
Peter