From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu()
Date: Tue, 7 Mar 2017 13:56:26 +0100 [thread overview]
Message-ID: <20170307125626.GA8578@gmail.com> (raw)
In-Reply-To: <20170307103812.yuv7tlfsjmxfmyyr@pd.tnic>
* Borislav Petkov <bp@alien8.de> wrote:
> On Tue, Mar 07, 2017 at 10:06:38AM +0100, Ingo Molnar wrote:
> > The local labels syntax is silly, I always end up looking twice to make sense of
> > 'Ljump' or 'Lwhatever' ;-)
> >
> > We cannot do anything about that - but we can name our symbols to work it around.
> > But the price is the extra underscore in the symbol name...
>
> Sure, but other labels in this file don't have the preceding "_".
Yeah, and that would make it all inconsistent - fair enough.
Ok, I'll apply your patch as-is.
> Perhaps we should agree on a convention for the local labels naming in
> our asm and adhere to it...
Too much churn I suspect, plus we'd generate extra churn when people inevitably
get it wrong.
Thanks,
Ingo
next prev parent reply other threads:[~2017-03-07 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 9:56 [PATCH 1/2] x86/head_64.S: Rename start_cpu() Borislav Petkov
2017-03-04 9:56 ` [PATCH 2/2] x86/head_64.S: Pass struct boot_params' virtual address to C Borislav Petkov
2017-03-07 9:11 ` Ingo Molnar
2017-03-07 10:40 ` Borislav Petkov
2017-03-07 9:06 ` [PATCH 1/2] x86/head_64.S: Rename start_cpu() Ingo Molnar
2017-03-07 10:38 ` Borislav Petkov
2017-03-07 12:56 ` Ingo Molnar [this message]
2017-03-07 13:01 ` [tip:x86/boot] x86/boot/64: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307125626.GA8578@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).