From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932722AbdCGO4m (ORCPT ); Tue, 7 Mar 2017 09:56:42 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33607 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755476AbdCGO4I (ORCPT ); Tue, 7 Mar 2017 09:56:08 -0500 Date: Tue, 7 Mar 2017 13:56:26 +0100 From: Ingo Molnar To: Borislav Petkov Cc: X86 ML , LKML , Thomas Gleixner Subject: Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu() Message-ID: <20170307125626.GA8578@gmail.com> References: <20170304095611.11355-1-bp@alien8.de> <20170307090638.GC6946@gmail.com> <20170307103812.yuv7tlfsjmxfmyyr@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170307103812.yuv7tlfsjmxfmyyr@pd.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Tue, Mar 07, 2017 at 10:06:38AM +0100, Ingo Molnar wrote: > > The local labels syntax is silly, I always end up looking twice to make sense of > > 'Ljump' or 'Lwhatever' ;-) > > > > We cannot do anything about that - but we can name our symbols to work it around. > > But the price is the extra underscore in the symbol name... > > Sure, but other labels in this file don't have the preceding "_". Yeah, and that would make it all inconsistent - fair enough. Ok, I'll apply your patch as-is. > Perhaps we should agree on a convention for the local labels naming in > our asm and adhere to it... Too much churn I suspect, plus we'd generate extra churn when people inevitably get it wrong. Thanks, Ingo