From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932666AbdCGPiA (ORCPT ); Tue, 7 Mar 2017 10:38:00 -0500 Received: from mail.kernel.org ([198.145.29.136]:42482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349AbdCGPhw (ORCPT ); Tue, 7 Mar 2017 10:37:52 -0500 Date: Tue, 7 Mar 2017 12:28:30 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com Subject: Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option Message-ID: <20170307152830.GB7670@kernel.org> References: <20170307150851.22304-1-namhyung@kernel.org> <20170307150851.22304-3-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170307150851.22304-3-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu: > The -q/--quiet option is to suppress any message. Sometimes users just > want to run the command and it can be used for that case. > +++ b/tools/perf/builtin-buildid-cache.c > @@ -311,6 +311,7 @@ int cmd_buildid_cache(int argc, const char **argv, > OPT_INCR('v', "verbose", &verbose, "be more verbose"), > + OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"), > OPT_END() > }; > const char * const buildid_cache_usage[] = { > @@ -326,6 +327,9 @@ int cmd_buildid_cache(int argc, const char **argv, > > + if (quiet) > + perf_quiet_option(); > + Hey, I see that this is done lots of times, can't we use that parent option stuff? Or some fallback we can have in perf's main() for thing like this? - Arnaldo