Re: [PATCH] blk: improve order of bio handling in generic_make_request()

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On Mon 2017-03-06 10:43:59, Jack Wang wrote:
> 
> 
> On 06.03.2017 05:40, NeilBrown wrote:
> > On Fri, Mar 03 2017, Jack Wang wrote:
> >>
> >> Thanks Neil for pushing the fix.
> >>
> >> We can optimize generic_make_request a little bit:
> >> - assign bio_list struct hold directly instead init and merge
> >> - remove duplicate code
> >>
> >> I think better to squash into your fix.
> > 
> > Hi Jack,
> >  I don't object to your changes, but I'd like to see a response from
> >  Jens first.
> >  My preference would be to get the original patch in, then other changes
> >  that build on it, such as this one, can be added.  Until the core
> >  changes lands, any other work is pointless.
> > 
> >  Of course if Jens wants a this merged before he'll apply it, I'll
> >  happily do that.
> > 
> > Thanks,
> > NeilBrown
> 
> Hi Neil,
> 
> Totally agree, let's wait for Jens's decision.
> 
> Hi Jens,
> 
> Please consider this fix also for stable 4.3+ 

Stable? We don't put this into stable, with exception of minimal fixes
for real bugs...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]