From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756190AbdCGVHW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Mar 2017 16:07:22 -0500
Received: from aserp1050.oracle.com ([141.146.126.70]:45437 "EHLO
        aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751955AbdCGVHS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Mar 2017 16:07:18 -0500
Date: Tue, 7 Mar 2017 20:24:38 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrea Ghittino <aghittino@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        ganesh.krishna@microchip.com, aditya.shankar@microchip.com
Subject: Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type
 assignment
Message-ID: <20170307172438.GI4171@mwanda>
References: <20170306211106.GA9885@myhd3>
 <20170307172304.GH4171@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170307172304.GH4171@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserp1040.oracle.com [141.146.126.69]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 07, 2017 at 08:23:04PM +0300, Dan Carpenter wrote:
> This commit doesn't tell me if you though about what you are doing at
> all.  We get so many commits where people just randomly do random endian
> things...  Did you think about this?  Could you resend with a better
> commit message?
> 

The commit message should say what the user visible effects of this
bug fix are going to be.

regards,
dan carpenter