From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbdCGRdW (ORCPT ); Tue, 7 Mar 2017 12:33:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25583 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755596AbdCGRct (ORCPT ); Tue, 7 Mar 2017 12:32:49 -0500 Date: Tue, 7 Mar 2017 20:31:13 +0300 From: Dan Carpenter To: Mark Stenglein Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Message-ID: <20170307173112.GK4171@mwanda> References: <20170306020912.21046-1-mark@stengle.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170306020912.21046-1-mark@stengle.in> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote: > Fixed a coding style issue. > > Signed-off-by: Mark Stenglein > --- > drivers/staging/wlan-ng/hfa384x.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h > index 5f1851c85f12..f19984747b1e 100644 > --- a/drivers/staging/wlan-ng/hfa384x.h > +++ b/drivers/staging/wlan-ng/hfa384x.h > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx { > enum ctlx_state state; /* Tracks running state */ > > struct completion done; > + > volatile int reapable; /* Food for the reaper task */ No blank line needed. The original is OK. (Except for the volatile is wrong obviously). regards, dan carpenter