From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cheah Kok Cheong <thrust73@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files"
Date: Wed, 8 Mar 2017 08:54:47 +0300 [thread overview]
Message-ID: <20170307195149.GA10722@mwanda> (raw)
In-Reply-To: <b96cfe8f8b63ff70d8bc3c34bff24ea0fbfc191d.1488654618.git.thrust73@gmail.com>
On Sun, Mar 05, 2017 at 03:22:33AM +0800, Cheah Kok Cheong wrote:
> If comedi module is loaded with the following max allowed parameter
> [comedi_num_legacy_minors=48], subsequent loading of an auto-configured
> device will fail.
Don't set comedi_num_legacy_minors=48, then?
This doesn't seem like the right fix at all. Why only allow one auto
configured board? Why not 5 or 10?
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-08 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 19:22 [PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Cheah Kok Cheong
2017-03-04 19:22 ` [PATCH 2/2] Staging: comedi: comedi_fops: Fix "out of minor numbers for board device files" Cheah Kok Cheong
2017-03-08 5:54 ` Dan Carpenter [this message]
2017-03-08 10:08 ` Cheah Kok Cheong
2017-03-08 11:13 ` Ian Abbott
2017-03-08 16:59 ` Cheah Kok Cheong
2017-03-07 19:01 ` [PATCH 1/2] Staging: comedi: comedi_fops: Change comedi_num_legacy_minors type Greg KH
2017-03-08 9:38 ` Cheah Kok Cheong
2017-03-08 9:45 ` Greg KH
2017-03-08 10:16 ` Cheah Kok Cheong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307195149.GA10722@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thrust73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox