From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752738AbdCHL5R (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Mar 2017 06:57:17 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33794 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752110AbdCHL5P (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Mar 2017 06:57:15 -0500
Date: Wed, 8 Mar 2017 11:47:37 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Wu Fengguang <fengguang.wu@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@suse.de>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Borislav Petkov <bp@alien8.de>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>, Brian Gerst <brgerst@gmail.com>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] x86/asm: Optimize clear_page()
Message-ID: <20170308104737.GA13961@gmail.com>
References: <20170215111927.emdgxf2pide3kwro@pd.tnic>
 <tip-49ca7bb328c630dd43be626534b49e19513296fd@git.kernel.org>
 <CAE9FiQU1NozwtPj9YFQjrmJO0CDw2XSqN3HLN4rn2iThFiO7dw@mail.gmail.com>
 <20170307073012.GA15693@gmail.com>
 <CAE9FiQX2xKUKbjf4N6pasSAeMm3qX4h6+DAoNwsdYe_qtZ08dA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE9FiQX2xKUKbjf4N6pasSAeMm3qX4h6+DAoNwsdYe_qtZ08dA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Yinghai Lu <yinghai@kernel.org> wrote:

> On Mon, Mar 6, 2017 at 11:30 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> On Wed, Mar 1, 2017 at 1:47 AM, tip-bot for Borislav Petkov
> >> <tipbot@zytor.com> wrote:
> >> > Commit-ID:  49ca7bb328c630dd43be626534b49e19513296fd
> >> > Gitweb:     http://git.kernel.org/tip/49ca7bb328c630dd43be626534b49e19513296fd
> >> > Author:     Borislav Petkov <bp@suse.de>
> >> > AuthorDate: Thu, 9 Feb 2017 01:34:49 +0100
> >> > Committer:  Ingo Molnar <mingo@kernel.org>
> >> > CommitDate: Wed, 1 Mar 2017 10:18:32 +0100
> >> >
> >> > x86/asm: Optimize clear_page()
> >> >
> >> > Currently, we CALL clear_page() which then JMPs to the proper function
> >> > chosen by the alternatives.
> >> >
> >> > What we should do instead is CALL the proper function directly. (This
> >> > was something Ingo suggested a while ago). So let's do that.
> >>
> >> looks like this one broke the kexec.
> >> after revert it back, kexec work again.
> >
> > Ok, this should be fixed in the new version I just pushed out:
> >
> >   f25d38475519 x86/asm: Optimize clear_page()
> >
> > Please let me know if it doesn't.
> 
> Yes. new commit works with kexec.
> 
> Thanks

Thanks for testing!

	Ingo