From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbdCHMes (ORCPT ); Wed, 8 Mar 2017 07:34:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57164 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbdCHMen (ORCPT ); Wed, 8 Mar 2017 07:34:43 -0500 Date: Wed, 8 Mar 2017 13:34:17 +0100 From: Greg Kroah-Hartman To: Vignesh R Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() Message-ID: <20170308123417.GA3981@kroah.com> References: <20170308121943.29340-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170308121943.29340-1-vigneshr@ti.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 08, 2017 at 05:49:43PM +0530, Vignesh R wrote: > Passing "serial" as name during request_irq() results in all serial port > irqs have same name. This does not help much to easily identify which > irq belongs to which serial port instance. Therefore pass dev_name() > during request_irq() so that better identifiable name is listed for > serial ports in cat /proc/interrupts output. > > Output of cat /proc/interrupts > Before this patch: > 26: 689 0 GICv2 309 Edge serial > After this patch: > 26: 696 0 GICv2 309 Edge 2530c00.serial > > Signed-off-by: Vignesh R I need a "full" name here, unless you really do sign legal documents with just one letter as a last/sur-name? thanks, greg k-h