From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974AbdCHRYk (ORCPT ); Wed, 8 Mar 2017 12:24:40 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34150 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998AbdCHRYi (ORCPT ); Wed, 8 Mar 2017 12:24:38 -0500 Date: Wed, 8 Mar 2017 18:24:33 +0100 From: Ingo Molnar To: Linus Torvalds Cc: Linux Kernel Mailing List , Peter Zijlstra , Thomas Gleixner , Andrew Morton Subject: Re: [GIT PULL] sched.h split-up Message-ID: <20170308172433.GB3301@gmail.com> References: <20170303013646.GA32094@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Torvalds wrote: > On Tue, Mar 7, 2017 at 3:33 PM, Linus Torvalds > wrote: > > > > But as mentioned - this is untested. It seems to build, and it looks > > "ObviouslyCorrect(tm)", but I didn't actually try to boot it. > > Well, it boots, but it's not like there are all that many users of the > wait_event_interruptible*_locked*() interfaces, so it's dubious that I > actually exercised the changes all that much (if at all). > > Of course, that's just more reason to *not* have it be some big macro > expansion in a header file that requires other includes. Basically, > this interface isn't worth the header inclusion pain. > > And no, I didn't try to see how many > > #include > > I could try to remove with this. > > But I *did* verify that I could now build that fs/overlayfs/util.c > file with that #include removed. > > That's the case that caused a semantic merge issue for me - but I > don't know how many others Ingo added as part of the split-up. I suspect wait_event_hrtimeout*() has a similar conceptual problem with linux/hrtimer.h, because it uses hrtimer APIs but doesn't include the header - but fortunately that API variant does not appear to be used much at the moment: only fs/aio.c uses wait_event_interruptible_hrtimeout(), but it includes sched.h which includes hrtimer.h. So Ack on your patch. Also, to be honest I'm also not looking forward to converting 20+ wait_event*() macros to a fragile state machine, so I wouldn't mind it if your patch was the final solution to this problem! ;-) Thanks, Ingo