From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbdCHVfy (ORCPT ); Wed, 8 Mar 2017 16:35:54 -0500 Received: from mail.kernel.org ([198.145.29.136]:41562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138AbdCHVfw (ORCPT ); Wed, 8 Mar 2017 16:35:52 -0500 Date: Wed, 8 Mar 2017 13:35:46 -0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page Message-ID: <20170308213546.GB5483@jaegeuk.local> References: <20170306215102.3807-1-jaegeuk@kernel.org> <8fa2118d-1da0-29f6-a755-fd661333d05d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fa2118d-1da0-29f6-a755-fd661333d05d@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08, Chao Yu wrote: > On 2017/3/7 5:51, Jaegeuk Kim wrote: > > If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page > > during f2fs_evict_inode(), which doesn't need to do. > > Hmm...should not allow other using of inode->i_ino in following codes of > f2fs_evict_inode, right? Right. > > Thanks, > > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/inode.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > index 24bb8213d974..ef8610bf950f 100644 > > --- a/fs/f2fs/inode.c > > +++ b/fs/f2fs/inode.c > > @@ -411,7 +411,10 @@ void f2fs_evict_inode(struct inode *inode) > > stat_dec_inline_dir(inode); > > stat_dec_inline_inode(inode); > > > > - invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, inode->i_ino); > > + /* ino == 0, if f2fs_new_inode() was failed t*/ > > + if (inode->i_ino) > > + invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, > > + inode->i_ino); > > if (xnid) > > invalidate_mapping_pages(NODE_MAPPING(sbi), xnid, xnid); > > if (inode->i_nlink) { > >