From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751684AbdCIUSd (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 15:18:33 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49376 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750726AbdCIUSa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 15:18:30 -0500
X-ME-Sender: <xms:brjBWMPdkmRehY4t8RkokbREVOmyrArlpGcNzAB9F-gF2_BS0uDwjw>
X-Sasl-enc: a+OcJ+i3DiGgLMPID4GetTqmSwQOdKM78UUhTja4tOF9 1489090669
Date: Fri, 10 Mar 2017 07:17:46 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Galbraith <efault@gmx.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] 72042a8c7b01 x86/purgatory: Make functions and
 variables static
Message-ID: <20170309201746.GC4615@eros>
References: <1489068254.4381.18.camel@gmx.de>
 <alpine.DEB.2.20.1703091849400.3521@nanos>
 <1489083766.5228.10.camel@gmx.de>
 <alpine.DEB.2.20.1703092010340.3832@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1703092010340.3832@nanos>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2017 at 08:11:03PM +0100, Thomas Gleixner wrote:
> On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > On Thu, 2017-03-09 at 18:50 +0100, Thomas Gleixner wrote:
> > > On Thu, 9 Mar 2017, Mike Galbraith wrote:
> > > 
> > > > Greetings,
> > > > 
> > > > I bisected kdump breakage to $subject, and verified the identified
> > > > culprit via revert.  Seems kexec needs those variables as they were.
> > > 
> > > Yuck. That does not make any sense at all. I'll try to figure out why.
> > 
> > Dunno, but I did find this.
> > 
> > git@homer:..kexec-tools/kexec-tools-2.0.5> grep -IR 'elf_rel_.*symbol' . | egrep 'backup_|digest'|grep x86_64
> > ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_start",
> > ./kexec/arch/x86_64/kexec-x86_64.c:     elf_rel_set_symbol(&info->rhdr, "backup_src_size",
> > ./kexec/arch/x86_64/kexec-x86_64.c:             elf_rel_set_symbol(&info->rhdr, "backup_start",
> 
> Came so far as well. Lovely undocumented dependencies.....

I'm out of my depth on this one. If there is some task I can do to
save you time or effort, point me at it.

thanks,
Tobin.